Den lör 5 juli 2025 kl 18:48 skrev Graham Leggett <minf...@sharp.fm.invalid >:
> On 05 Jul 2025, at 11:05, Branko Čibej <br...@apache.org> wrote: > > > Please use the log format we're accustomed to, and try to limit line > lengths to 80 columns. It's kind of a tradition here. > > > > For log messages, we follow Subversion's guidelines: > > > https://subversion.apache.org/docs/community-guide/conventions.html#log-messages > > Does this work? > I appreciated the detailed bullet points in the previous log message explaining what would happen. It helps me get an understanding of the overall change. Then you can also keep the description quite short (or very specific) under each file. > > Add support for SSL error handling > > [minfrin@rocky9 subversion]$ svn info > https://svn.example.com/svn/example/core/ > svn: E170013: Unable to connect to a repository at URL ' > https://svn.example.com/svn/example/core' > svn: E120170: TLS: error:0308010C:digital envelope routines::unsupported > svn: E120170: TLS: could not parse PKCS12: /home/minfrin/.my-cert.p12 > > * serf_bucket_types.h > (serf_ssl_error_cb_set): Allow the registration of an optional callback > to > which error strings will be sent. > > * buckets/ssl_buckets.c > (serf_ssl_context_t): Add error_callback. > (log_ssl_error): Trigger error callback. > ^^ These are excellent and just about enough (status_from_ssl_error): Support SSL_ERROR_WANT_X509_LOOKUP. Client side > SSL > certificate errors now cause the client side to abort the connection. > Previously no certificate was silently sent, and the error was access > denied > from the server. ^^ Here I would have left the detailed description in the bullet points, just saying Support SSL_ERROR_WANT_X509_LOOKUP is probably enough. (ssl_need_client_cert): Trigger callback with error explanation, remove an > infinite loop when the PKCS12 file cannot be opened. > (serf_ssl_error_cb_set): New function. > (ssl_new_session): Init the callback. > ^^ All good > > (I have updated the commit) > > Regards, > Graham > -- > > Thanks, Daniel
