I think it is better to decoupled package it if we want to add something enhanced, but not just only modified it and then keep in the third-party. Anyway , third-party is not a regular and recommended way to using golang libraries.
Best Regards, --- Zen Lin zenlintechnofr...@gmail.com Focused on Micro Service and Apache ServiceComb 2018-06-07 11:32 GMT+08:00 Willem Jiang <willem.ji...@gmail.com>: > If we changed the code, we should move it third party directory. > @Asif @Cuiyihua Could you double check with YangBo？ > > > Willem Jiang > > Twitter: willemjiang > Weibo: 姜宁willem > > On Thu, Jun 7, 2018 at 10:29 AM, Yang Bo <oaky...@gmail.com> wrote: > > > Hi All, > > > > Currently we store github.com/go-ecosystem/grpc-gateway and > > go-grpc-prometheus under the vendor directory. > > > > The vendor directory should only contain manifest file and all other code > > should be fetched from third party repository. > > > > If we have made some modification to those libraries, then we need to > move > > them to a proper place. > > > > -- > > Best Regards, > > Yang. > > >
