we do not change the code in go-ecosystem package and we can remove these files from project
Just make sure the same version of this package compiled with etcd components when make the release. ------------------ ???????? ------------------ ??????: "willem.jiang"<willem.ji...@gmail.com>; ????????: 2018??6??7??(??????) ????11:32 ??????: "dev"<dev@servicecomb.apache.org>; ????: Re: [Discuss] Should we clean up vendor/github.com/go-ecosystem for ServiceCenter If we changed the code, we should move it third party directory. @Asif @Cuiyihua Could you double check with YangBo?? Willem Jiang Twitter: willemjiang Weibo: ????willem On Thu, Jun 7, 2018 at 10:29 AM, Yang Bo <oaky...@gmail.com> wrote: > Hi All, > > Currently we store github.com/go-ecosystem/grpc-gateway and > go-grpc-prometheus under the vendor directory. > > The vendor directory should only contain manifest file and all other code > should be fetched from third party repository. > > If we have made some modification to those libraries, then we need to move > them to a proper place. > > -- > Best Regards, > Yang. >
