+1 to @Kirin Wang's suggestion. start.servicecomb.io should be support Spring Boot 2 too, Chuanzhi Boke also use start.servicecomb.io to develop coursewares now. It should be created a sub-task to tracing.
Best Wishes & Regards ------------------------------- Mabin Kirin Wang <wangqilint...@gmail.com> 于2018年7月23日周一 上午9:23写道： > I think we also have a sub-task of support Spring Boot 2 , which is add > Spring Boot 2.X option in start.servicecomb.io . > > Zen Lin <zenlintechnofr...@gmail.com> 于2018年7月23日周一 上午9:15写道： > > > +1 to Willem's suggestion. > > Could someone ask yaohaishi to create a issue track for this, upgrade to > > support Spring Boot2. > > And when he find an actual issue on testing it, can create a sub issue > > under the issue of "upgrade to support Spring Boot2". > > > > Thus, Mabin and the users can know the detail progress or report what > > issue they meet through the issue. > > > > Best Regards, > > --- > > Zen Lin > > zenlintechnofr...@gmail.com > > Focused on Micro Service and Apache ServiceComb > > > > > > Willem Jiang <willem.ji...@gmail.com> 于2018年7月20日周五 下午4:40写道： > > > > > SCB-758 is a big task. I don't think we need to wait for it done to > > > support Spring Boot 2.x. > > > Yaohaishi already did some test on it, we just need to keep fix the > > actual > > > issue we find > > > > > > my suggestion is we support Spring Boot 1.x by default, and add a > Spring > > > Boot 2.x profile to the user who want to use Spring Boot 2.x. > > > > > > > > > > > > Willem Jiang > > > > > > Twitter: willemjiang > > > Weibo: 姜宁willem > > > > > > On Fri, Jul 20, 2018 at 4:25 PM, Bin Ma <mabin1...@gmail.com> wrote: > > > > > > > Currently I have recommended user like Chuanzhi Boke to develop based > > on > > > > the spring boot1.x version to ensure that user development is not > > > blocked. > > > > > > > > I agree with bimsy's idea,users' demands and scenes are clear,an task > > > > should be created to trace. > > > > > > > > As I know, SCB-758(https://issues.apache.org/jira/browse/SCB-758) > is a > > > > task > > > > to remove the dependency of java-chassis on spring, I'm not sure if > > this > > > > task is completed first, and it is more helpful to support the > > > springboot2 > > > > ? > > > > > > > > 2018-07-20 11:24 GMT+08:00 Willem Jiang <willem.ji...@gmail.com>: > > > > > > > > > From the Spring Boot2 migration guide[1], the class package and > name > > > was > > > > > changed. > > > > > > > > > > We may need to create different module to handle the class package > > > change > > > > > issue. > > > > > > > > > > [1] > > > > > https://github.com/spring-projects/spring-boot/wiki/ > > > > > > Spring-Boot-2.0-Migration-Guide#embedded-containers-package-structure > > > > > > > > > > > > > > > > > > > > Willem Jiang > > > > > > > > > > Twitter: willemjiang > > > > > Weibo: 姜宁willem > > > > > > > > > > On Fri, Jul 20, 2018 at 10:29 AM, yhs0092 <yhs0...@163.com> wrote: > > > > > > > > > > > I tried to upgrade Java-Chassis to support SpringBoot2 before, > but > > > > > failed. > > > > > > > > > > > > > > > > > > There are two problems. The first one is in our bean.xml file， > the > > > xsd > > > > > > file is imported like below: > > > > > > ``` > > > > > > > > classpath:org/springframework/beans/factory/xml/spring-beans-3.0.xsd > > > > > > ``` > > > > > > but 3.0 version xsd file does not exist anymore. > > > > > > > > > > > > This is still resolvable, but for the second problem, I still > > haven't > > > > > > found a way to resolve it. > > > > > > > > > > > > > > > > > > When my service demo is started, an error occurs: > > > > > > ``` > > > > > > 2018-03-13 22:57:18.396 WARN 11116 --- [ main] > > > > > > ConfigServletWebServerApplicationContext : Exception encountered > > > > during > > > > > > context initialization - cancelling refresh attempt: > > > > > > org.springframework.beans.factory.BeanDefinitionStoreException: > > > Failed > > > > > to > > > > > > parse configuration class [org.apache.servicecomb. > > > > > > springboot.starter.transport.RestServletInitializer]; nested > > > exception > > > > > is > > > > > > java.io.FileNotFoundException: class path resource > > > > > > [org/springframework/boot/context/embedded/ > > > > > AbstractConfigurableEmbeddedServletContainer.class] > > > > > > cannot be opened because it does not exist > > > > > > ``` > > > > > > Because AbstractConfigurableEmbeddedServletContainer is removed > in > > > > > > SpringBoot2, and our RestServletInitializer is extended from this > > > > class, > > > > > > maybe we cannot upgrade to SpringBoot2 by simply change the maven > > > > > > dependency. > > > > > > And once we refactor our RestServletInitializer, the java-chassis > > may > > > > not > > > > > > be compatible with SpringBoot1. > > > > > > > > > > > > > > > > > > > > > > > > 在 2018-07-20 08:57:05，"wjm wjm" <zzz...@gmail.com> 写道： > > > > > > >not enough, must exclude old spring also > > > > > > > > > > > > > >2018-07-20 6:44 GMT+08:00 Willem Jiang <willem.ji...@gmail.com > >: > > > > > > > > > > > > > >> How about let user override the version of Spring Boot in > their > > > > > > application > > > > > > >> and give it a try. > > > > > > >> Just like what we do with JDK9 here[1] > > > > > > >> If there is any issue comes out, we can keep digging it. > > > > > > >> > > > > > > >> [1] > > https://github.com/apache/incubator-servicecomb-saga/issues/76 > > > > > > >> > > > > > > >> > > > > > > >> Willem Jiang > > > > > > >> > > > > > > >> Twitter: willemjiang > > > > > > >> Weibo: 姜宁willem > > > > > > >> > > > > > > >> On Thu, Jul 19, 2018 at 8:26 PM, Bin Ma <mabin1...@gmail.com> > > > > wrote: > > > > > > >> > > > > > > >> > Hi, > > > > > > >> > Java-chassis currently supports Spirng Boot 1.5.12 > version. > > > > > > >> > > > > > > > >> > In fact, some enterprise users develop their coursewares > > based > > > > on > > > > > > >> Spring > > > > > > >> > Boot2, so hopefully Java-chassis can support Spring Boot2, > > such > > > as > > > > > > >> Chuanzhi > > > > > > >> > Boke. > > > > > > >> > > > > > > > >> > I think it's neccessary to discuss the plan about > upgrading > > > > > > >> > Java-Chasssis to support Spring Boot2 to satisfy users' > > > scenario. > > > > > > >> > > > > > > > >> > Any thoughts and any troubles to upgrading, please feel > free > > > to > > > > > > discuss > > > > > > >> > here. > > > > > > >> > > > > > > > >> > > > > > > > > > > > > > > > > > > > > > > > > > > > -- > > > > Best Wishes & Regards > > > > ------------------------------- > > > > Mabin > > > > > > > > > >
