+1 We can add the vendor to SC folder, this will ease out the development of SC specially in China region where GFC blocks the downloading of google libs.
Regards Asif On Sat, 25 Aug 2018, 3:22 pm Yang Bo, <[email protected]> wrote: > +1 > > As for the Apache compliance, It's OK to include the vendor source code in > our repository. We can update the release script and exclude the vendor > directory when releasing. > > On Sat, Aug 25, 2018 at 4:20 PM Kirin Wang <[email protected]> > wrote: > > > +1 > > But may be we need to confirm if there are Apache compliance issue about > > it ? > > > > Xiaoliang Tian <[email protected]> 于2018年8月25日周六 上午10:48写道： > > > > > +1 Agree > > > the truth is go project can easily go into a dep hell and there is no > dep > > > tool can manage the complicated deps > > > > > > checkout how go project does > > > https://github.com/istio/istio/tree/master/vendor > > > https://github.com/coreos/etcd/tree/master/vendor > > > > > > dep management is torturing go developers now > > > > > > Sure <[email protected]> 于2018年8月25日周六 上午10:39写道： > > > > > > > Developers from China complain it is hard to go get the 3rd depends > > > source > > > > code of sc. > > > > I suggest add these source code in vendor directory in sc project, > like > > > > Istio and etcd project do. > > > > > > > > -- > Best Regards, > Yang. >
