+1 to move these code to the vertx which is best way for servicecomb and vertx.
Willem Jiang Twitter: willemjiang Weibo: 姜宁willem On Wed, Oct 31, 2018 at 9:00 AM wjm wjm <[email protected]> wrote: > > currently we > customized org.apache.servicecomb.transport.rest.vertx.RestBodyHandler > 1.disable upload feature when uploadDir is null, this is a general > requirement > 2.wrap some exceptions to JavaChassis exception, this is not a general > requirement > > if there is only customization 1, maybe we can try to raise a PR to vertx > otherwise we always forget to merge latest vertx logic to our code. > > maybe we can confirm if customization 2 is necessary.
