+1 for it. We could start from servicecomb-pack project first. We could enable this feature for the other sub projects if it goes well.
Any thoughts? Willem Jiang Twitter: willemjiang Weibo: 姜宁willem On Wed, Apr 3, 2019 at 2:56 PM Zheng Feng <zh.f...@gmail.com> wrote: > > Hi, > > I just wonder if we can enable this setting [1] on servicecomb-pack [2] and > it could be helpful when reviewing the PR. I think at least one people > review the changes and approve before merging it. We have to raise a JIRA > for the infra team to do this setting. So I post this message here to see > if the others have any thought. > > Regards, > Zheng Feng > > [1] > https://help.github.com/en/articles/enabling-required-reviews-for-pull-requests > [2] https://github.com/apache/servicecomb-pack