+1 We require at least one or two reviewers review for java-chassis in practice. We can make it required by adding this configuration.
------------------ ???????? ------------------ ??????: "zzzwjm"<zzz...@gmail.com>; ????????: 2019??4??3??(??????) ????10:23 ??????: "dev"<dev@servicecomb.apache.org>; ????: Re: [DISCUSS] Require the review before merging the PR +1 zhang_...@boco.com.cn <zhang_...@boco.com.cn> ??2019??4??3?????? ????3:25?????? > +1 > > > ?? 2019??4??3????????2:55??Zheng Feng <zh.f...@gmail.com> ?????? > > > > Hi, > > > > I just wonder if we can enable this setting [1] on servicecomb-pack [2] > and > > it could be helpful when reviewing the PR. I think at least one people > > review the changes and approve before merging it. We have to raise a JIRA > > for the infra team to do this setting. So I post this message here to see > > if the others have any thought. > > > > Regards, > > Zheng Feng > > > > [1] > > > https://help.github.com/en/articles/enabling-required-reviews-for-pull-requests > > [2] https://github.com/apache/servicecomb-pack > > > Zhang Lei. > > > >
