coveralls commented on issue #2169: using typeBasedSPI to refactor algorithm strategy and factory. URL: https://github.com/apache/incubator-shardingsphere/pull/2169#issuecomment-480751998 ## Pull Request Test Coverage Report for [Build 7509](https://coveralls.io/builds/22662882) * **15** of **17** **(88.24%)** changed or added relevant lines in **6** files are covered. * No unchanged relevant lines lost coverage. * Overall coverage decreased (**-0.02%**) to **54.413%** --- | Changes Missing Coverage | Covered Lines | Changed/Added Lines | % | | :-----|--------------|--------|---: | | [sharding-core/sharding-core-common/src/main/java/org/apache/shardingsphere/core/rule/MasterSlaveRule.java](https://coveralls.io/builds/22662882/source?filename=sharding-core%2Fsharding-core-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fcore%2Frule%2FMasterSlaveRule.java#L51) | 2 | 3 | 66.67% | [sharding-core/sharding-core-common/src/main/java/org/apache/shardingsphere/core/spi/algorithm/TypeBasedSPIServiceLoader.java](https://coveralls.io/builds/22662882/source?filename=sharding-core%2Fsharding-core-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fcore%2Fspi%2Falgorithm%2FTypeBasedSPIServiceLoader.java#L84) | 8 | 9 | 88.89% <!-- | **Total:** | **15** | **17** | **88.24%** | --> | Totals | [](https://coveralls.io/builds/22662882) | | :-- | --: | | Change from base [Build 7508](https://coveralls.io/builds/22661891): | -0.02% | | Covered Lines: | 8575 | | Relevant Lines: | 15759 | --- ##### 💛 - [Coveralls](https://coveralls.io)
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
