cherrylzhao commented on a change in pull request #122: Add a broadcast-table
example for sharding-jdbc
URL:
https://github.com/apache/incubator-shardingsphere-example/pull/122#discussion_r272947411
##########
File path:
example-common/repository-jdbc/src/main/java/org/apache/shardingsphere/example/common/jdbc/service/CommonServiceImpl.java
##########
@@ -17,60 +17,80 @@
package org.apache.shardingsphere.example.common.jdbc.service;
+import org.apache.shardingsphere.example.common.entity.Country;
import org.apache.shardingsphere.example.common.entity.Order;
import org.apache.shardingsphere.example.common.entity.OrderItem;
+import org.apache.shardingsphere.example.common.repository.CountryRepository;
import org.apache.shardingsphere.example.common.repository.OrderItemRepository;
import org.apache.shardingsphere.example.common.repository.OrderRepository;
import org.apache.shardingsphere.example.common.service.CommonService;
import java.util.ArrayList;
import java.util.List;
+import java.util.Locale;
public final class CommonServiceImpl implements CommonService {
-
+
private OrderRepository orderRepository;
-
+
private OrderItemRepository orderItemRepository;
-
+
+ private CountryRepository countryRepository;
Review comment:
you can add a CountryServiceImpl instead of modifying the commonServiceImpl
like we have done in UserServiceImpl. other scenario as Sharding, transaction,
orchestration don't need a broadcast-table.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
