Yes, using visitor is a standard way to visit the AST, it is better than previous way. Please go ahead.
------------------ Liang Zhang (John) Apache ShardingSphere & Dubbo Juan Pan <[email protected]> 于2020年1月9日周四 下午2:21写道： > Hi folks, > > > It is not common practice and prone to low performance that > `ExtractorEngine` and `FillerEngine` are used to get final SQL parsed > result based on AST generated by ANTLR at present. Upon investigation, we > would like to replace them with ANTLR visitor. > > > It is scheduled as a long-term task and a big change for our 5.x release, > and currently i am trying to do some basic work for our new branch[1]. > After the groundwork (Roughly estimated time is one week. ) is basically > laid, we would like to welcome anyone who is interested in it to join us > for this wonderful sharding parser. > > > Please watch this thread for follow-up. What’s more, welcome your any > comment and suggestion! > > > > > [1] > https://github.com/apache/incubator-shardingsphere/tree/sharding-parser-5.x > > > > > > > Juan Pan (Trista) > > Senior DBA & PPMC of Apache ShardingSphere(Incubating) > E-mail: [email protected] > > > >
