We can change issues #3956  and #4004 as bug, and keep #4054 and #4205 as
enhancement.

------------------

Liang Zhang (John)
Apache ShardingSphere & Dubbo


[email protected] <[email protected]> 于2020年2月10日周一 上午11:45写道:

> The enhancement has a little more in name than in reality. Maybe we need
> change all enhancement tags to bug tags.
>
>
> ------------------
>
> Liang Zhang (John)
> Apache ShardingSphere & Dubbo
>
>
> Zonglei Dong <[email protected]> 于2020年2月10日周一 上午9:57写道:
>
>> Hi Zhao Jun,
>>
>>
>> I was participated in discussing the 3918[1], I agree with that Metadata
>> model’s redesign is a big refactor 3922[2]
>>
>>
>> I suggest we can merge the 3918’s PR and not care of the Metadata model’s
>> redesign right now,
>> because if we don’t merge it, user may be always meet this bug in 4.x’s
>> version.
>>
>>
>> [1]: https://github.com/apache/incubator-shardingsphere/pull/3918 <
>> https://github.com/apache/incubator-shardingsphere/pull/3918>
>> [2]: https://github.com/apache/incubator-shardingsphere/issues/3922 <
>> https://github.com/apache/incubator-shardingsphere/issues/3922>
>>
>>
>> Thanks.
>> Best wishes.
>> Zonglei Dong
>> Apache ShardingSphere
>>
>>
>> On 02/10/2020 09:31,zhaojun<[email protected]> wrote:
>> Hi, Nicholas
>>
>> 3918[1] PR have introduced another bug, see issue 3995[2].
>> Metada model needs to redesign in 3992[3]
>> This will be a big refactor, so we don’t plan to include it in 4.0.1
>>
>>
>> [1]: https://github.com/apache/incubator-shardingsphere/pull/3918 <
>> https://github.com/apache/incubator-shardingsphere/pull/3918>
>> [2]: https://github.com/apache/incubator-shardingsphere/issues/3995 <
>> https://github.com/apache/incubator-shardingsphere/issues/3995>
>> [3]: https://github.com/apache/incubator-shardingsphere/issues/3922 <
>> https://github.com/apache/incubator-shardingsphere/issues/3922>
>>
>> ------------------
>> Zhao Jun (cherrylzhao)
>> Apache ShardingSphere & ServiceComb
>>
>> On Feb 9, 2020, at 8:18 PM, 蒋晓峰 <[email protected]> wrote:
>>
>> Hi zhaojun,
>> what about the pull request of
>> https://github.com/apache/incubator-shardingsphere/pull/3918? I thought
>> that this pull request is necessary to 4.0.1 version.
>>
>> Thanks,
>> Nicholas Jiang
>>
>> On Sun, Feb 9, 2020 at 3:44 PM zhaojun <[email protected]> wrote:
>>
>> Hi, ShardingSphere community,
>>
>> I’d like to be the release manager of 4.0.1 version.
>> We have done some bug fixes and performance optimization in past month
>> based on 4.0.0.
>> If there is no other requirement, I think we can start to release 4.0.1
>> recently.
>>
>>
>> ## Bug fixes
>>
>> 3975  oracle insert SQL could not work in encrypt mode
>> 3997  proxy for PostgreSQL decode parameters error in all types except
>> String
>> 4022  none sharding strategy could not config in spring-boot
>> 4052  plain column could not get from resultSet in sharding-encrypt mode
>> 4173  wasNull field was wrong in GroupByStreamMergeResult
>>
>>
>> ## Enhancement
>>
>> 3956  using guava cache to improve parsing performance
>> 4004  optimize COM_STM_EXECUTE of MySQL to support sysbench
>> 4054  optimize antlr performance using two-stage parsing strategy
>> 4205  add class filter constructor to restrict the illegal class from YAML
>>
>> Thanks to these contributors for their code commits.
>> -  tuohai666,  xiyelife, SteNicholas,  KomachiSion,  beckhampu,  plazmdk
>>
>> Any other task missing here? Please feel free to let me know.
>>
>> ------------------
>> Zhao Jun (cherrylzhao)
>> Apache ShardingSphere & ServiceComb
>>
>>

Reply via email to