It is good to remove them for unused code. ------------------
Liang Zhang (John) Apache ShardingSphere & Dubbo Juan Pan <[email protected]> 于2020年2月14日周五 下午8:55写道： > Hi > > > I assumed this is a lazy consensus, so PR [1] was raised to fix this > issue. > > > If you have any objection, please speak up. > > > [1] https://github.com/apache/incubator-shardingsphere/pull/4290 > Juan Pan (Trista) > > Senior DBA & PPMC of Apache ShardingSphere(Incubating) > E-mail: [email protected] > > > > > On 02/13/2020 14:43，Juan Pan<[email protected]> wrote： > Hi everyone, > > > I found the class member `parametersCount` and > `parameterMarkerStartIndex` of `WhereSegment .java` are written, but do not > used or read by any other objects. > > > So i plan to remove them to simply our parsing module and integrated > tests. If i miss something, please tell me ASAP. > > > Regards, > > > Juan Pan (Trista) > > Senior DBA & PPMC of Apache ShardingSphere(Incubating) > E-mail: [email protected] > > > >
