In previous refactor work of visitor, I found that this segment has no sense in parser, therefore I agree with you that to remove them to simply our parsing module and integrated tests.
On Thu, Feb 13, 2020 at 2:44 PM Juan Pan <[email protected]> wrote: > Hi everyone, > > > I found the class member `parametersCount` and > `parameterMarkerStartIndex` of `WhereSegment .java` are written, but do not > used or read by any other objects. > > > So i plan to remove them to simply our parsing module and integrated > tests. If i miss something, please tell me ASAP. > > > Regards, > > > Juan Pan (Trista) > > Senior DBA & PPMC of Apache ShardingSphere(Incubating) > E-mail: [email protected] > > > >
