LGTM

...with a few minor suggestions.


http://codereview.appspot.com/380041/diff/1/4
File
java/gadgets/src/main/java/org/apache/shindig/gadgets/render/Renderer.java
(right):

http://codereview.appspot.com/380041/diff/1/4#newcode81
java/gadgets/src/main/java/org/apache/shindig/gadgets/render/Renderer.java:81:
if (gadget.getCurrentView().getType() == View.ContentType.URL &&
FYI: this isn't proxied, this is type=url. Logic is fine, CL description
a little off ;)

http://codereview.appspot.com/380041/diff/1/4#newcode83
java/gadgets/src/main/java/org/apache/shindig/gadgets/render/Renderer.java:83:
"1".equals(gadget.getContext().getParameter("caja")))) {
we should probably move this check to a utility method

http://codereview.appspot.com/380041/diff/1/2
File
java/server/src/test/java/org/apache/shindig/server/endtoend/EndToEndTest.java
(right):

http://codereview.appspot.com/380041/diff/1/2#newcode205
java/server/src/test/java/org/apache/shindig/server/endtoend/EndToEndTest.java:205:
}
Interested to hear more -- where is this error thrown? What's in the
output?

http://codereview.appspot.com/380041/show

Reply via email to