http://codereview.appspot.com/380041/diff/1/4 File java/gadgets/src/main/java/org/apache/shindig/gadgets/render/Renderer.java (right):
http://codereview.appspot.com/380041/diff/1/4#newcode81 java/gadgets/src/main/java/org/apache/shindig/gadgets/render/Renderer.java:81: if (gadget.getCurrentView().getType() == View.ContentType.URL && On 2010/03/10 01:56:06, johnfargo wrote:
FYI: this isn't proxied, this is type=url. Logic is fine, CL
description a
little off ;)
Done. Fixed the CL description. http://codereview.appspot.com/380041/diff/1/4#newcode81 java/gadgets/src/main/java/org/apache/shindig/gadgets/render/Renderer.java:81: if (gadget.getCurrentView().getType() == View.ContentType.URL && On 2010/03/10 08:28:29, chirag wrote:
Minor nit: The check "gadget.getCurrentView().getType() == View.ContentType.URL"
is already
being done on line 88.
Would it make sense to simply throw an exception if caja is enabled at
line 89? Done. http://codereview.appspot.com/380041/diff/1/4#newcode83 java/gadgets/src/main/java/org/apache/shindig/gadgets/render/Renderer.java:83: "1".equals(gadget.getContext().getParameter("caja")))) { Good idea. Done. On 2010/03/10 01:56:06, johnfargo wrote:
we should probably move this check to a utility method
http://codereview.appspot.com/380041/show
