http://codereview.appspot.com/3734041/diff/134002/java/gadgets/src/test/java/org/apache/shindig/gadgets/uri/DefaultConcatUriManagerTest.java File java/gadgets/src/test/java/org/apache/shindig/gadgets/uri/DefaultConcatUriManagerTest.java (right):
http://codereview.appspot.com/3734041/diff/134002/java/gadgets/src/test/java/org/apache/shindig/gadgets/uri/DefaultConcatUriManagerTest.java#newcode133 java/gadgets/src/test/java/org/apache/shindig/gadgets/uri/DefaultConcatUriManagerTest.java:133: if (jsonParams.keySet().contains(uri.getUris().get(0).toString())) { Assign uri.getUris().get(0).toString() to a variable calle currentUri for better readability in this block. http://codereview.appspot.com/3734041/diff/134002/java/gadgets/src/test/java/org/apache/shindig/gadgets/uri/DefaultConcatUriManagerTest.java#newcode324 java/gadgets/src/test/java/org/apache/shindig/gadgets/uri/DefaultConcatUriManagerTest.java:324: uriBasicCheck(concatUris.get(0).getUris().get(0), host, path, 9, type, "1", "1", versions[0]); Any idea why we get debug and nocache parameters as "1" here instead of "0" as in typeJsBatchSplitBatched? http://codereview.appspot.com/3734041/diff/134002/java/gadgets/src/test/java/org/apache/shindig/gadgets/uri/DefaultConcatUriManagerTest.java#newcode380 java/gadgets/src/test/java/org/apache/shindig/gadgets/uri/DefaultConcatUriManagerTest.java:380: private void uriBasicCheck(Uri uri, uriBasicCheck -> verifyBasicUriParameters or checkBasicUriParameters. http://codereview.appspot.com/3734041/diff/134002/java/gadgets/src/test/java/org/apache/shindig/gadgets/uri/DefaultConcatUriManagerTest.java#newcode381 java/gadgets/src/test/java/org/apache/shindig/gadgets/uri/DefaultConcatUriManagerTest.java:381: String host, Fix indentation for this line and the next few lines. http://codereview.appspot.com/3734041/diff/134002/java/gadgets/src/test/java/org/apache/shindig/gadgets/uri/DefaultConcatUriManagerTest.java#newcode401 java/gadgets/src/test/java/org/apache/shindig/gadgets/uri/DefaultConcatUriManagerTest.java:401: private void uriBasicCheck(Uri uri, uriBasicCheck -> verifyBasicUriParameters or checkBasicUriParameters. http://codereview.appspot.com/3734041/
