> On 2011-06-04 17:26:46, Henry Saputra wrote: > > http://svn.apache.org/repos/asf/shindig/trunk/java/common/src/main/java/org/apache/shindig/common/servlet/Authority.java, > > line 1 > > <https://reviews.apache.org/r/792/diff/3/?file=20486#file20486line1> > > > > ASF license
done > On 2011-06-04 17:26:46, Henry Saputra wrote: > > http://svn.apache.org/repos/asf/shindig/trunk/java/common/src/main/java/org/apache/shindig/common/servlet/Authority.java, > > line 4 > > <https://reviews.apache.org/r/792/diff/3/?file=20486#file20486line4> > > > > Needs comment about what this interface is for. done > On 2011-06-04 17:26:46, Henry Saputra wrote: > > http://svn.apache.org/repos/asf/shindig/trunk/java/common/src/main/java/org/apache/shindig/common/servlet/BasicAuthority.java, > > line 1 > > <https://reviews.apache.org/r/792/diff/3/?file=20487#file20487line1> > > > > Add ASF license header done > On 2011-06-04 17:26:46, Henry Saputra wrote: > > http://svn.apache.org/repos/asf/shindig/trunk/java/common/src/main/java/org/apache/shindig/common/servlet/BasicAuthority.java, > > line 9 > > <https://reviews.apache.org/r/792/diff/3/?file=20487#file20487line9> > > > > Needs comment about what this class is for. done > On 2011-06-04 17:26:46, Henry Saputra wrote: > > http://svn.apache.org/repos/asf/shindig/trunk/java/common/src/main/java/org/apache/shindig/common/servlet/BasicAuthority.java, > > line 17 > > <https://reviews.apache.org/r/792/diff/3/?file=20487#file20487line17> > > > > indentation seems to be incorrect? I tried to make it align on the left with the previous parameter in Eclipse IDE. Just like this function in DefaultGuiceModule... protected List<String> defaultFeatures(@Named("shindig.features.default")String features, @Named("org.apache.shindig.features-extended")Set<String> extended) { I also see this style in other java code. still need 2 space here? - li ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/792/#review762 ----------------------------------------------------------- On 2011-06-06 14:45:37, li xu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/792/ > ----------------------------------------------------------- > > (Updated 2011-06-06 14:45:37) > > > Review request for shindig. > > > Summary > ------- > > This is a follow up for Issue 1534: > https://issues.apache.org/jira/browse/SHINDIG-1534 > > As discussed, default AuthorityProvider would implement following logic with > a Provider pattern > > 1. shindig.host & shindig.port defined in web.xml or system property > 2. host/port from HttpServletRequest > 3. Jetty host/port > > link to JIRA: https://issues.apache.org/jira/browse/SHINDIG-1541 > > > Diffs > ----- > > http://svn.apache.org/repos/asf/shindig/trunk/config/container.js 1127686 > > http://svn.apache.org/repos/asf/shindig/trunk/java/common/src/main/java/org/apache/shindig/common/PropertiesModule.java > 1127686 > > http://svn.apache.org/repos/asf/shindig/trunk/java/common/src/main/java/org/apache/shindig/common/servlet/Authority.java > PRE-CREATION > > http://svn.apache.org/repos/asf/shindig/trunk/java/common/src/main/java/org/apache/shindig/common/servlet/BasicAuthority.java > PRE-CREATION > > http://svn.apache.org/repos/asf/shindig/trunk/java/common/src/main/java/org/apache/shindig/common/servlet/BasicAuthorityProvider.java > PRE-CREATION > > http://svn.apache.org/repos/asf/shindig/trunk/java/common/src/main/java/org/apache/shindig/common/servlet/ServletRequestContext.java > 1127686 > > http://svn.apache.org/repos/asf/shindig/trunk/java/common/src/test/java/org/apache/shindig/common/servlet/BasicAuthorityProviderTest.java > PRE-CREATION > > http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/DefaultGuiceModule.java > 1127686 > > http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/uri/DefaultConcatUriManager.java > 1127686 > > http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/uri/DefaultIframeUriManager.java > 1127686 > > http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/uri/DefaultJsUriManager.java > 1127686 > > http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/uri/DefaultProxyUriManager.java > 1127686 > > http://svn.apache.org/repos/asf/shindig/trunk/java/server/src/main/webapp/WEB-INF/web.xml > 1127686 > > Diff: https://reviews.apache.org/r/792/diff > > > Testing > ------- > > built, passed unit tests. tested with > /samplecontainer/examples/commoncontainer/index.html > > > Thanks, > > li > >
