@Henry or @Paul, can you patch and commit this? LGTM but I'm swamped @ the moment :\
On Wed, Jun 8, 2011 at 10:06 AM, Li Xu <[email protected]> wrote: > Hello, John/Stanton/Henry > That patch has been posted for a while...would you please help moving it > forward? thanks! > li > > [image: Inactive hide details for "li xu" ---06/03/2011 06:11:22 > PM-------------------------------------------------------------- This]"li > xu" ---06/03/2011 06:11:22 > PM-------------------------------------------------------------- This is an > automatically generated e-mai > > > From: > "li xu" <[email protected]> > To: > [email protected], "li xu" <[email protected]>, Stanton > Sievers/Westford/IBM@Lotus, "shindig" <[email protected]> > Date: > 06/03/2011 06:11 PM > Subject: > Re: Review Request: Create default AuthorityProvider to support host/port > ------------------------------ > > > > > ----------------------------------------------------------- > > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/792/ > > ----------------------------------------------------------- > > (Updated 2011-06-03 21:37:58.289676) > > > Review request for shindig. > > > > Changes > ------- > > A new patch with comments addressed. thanks. > > > Summary > ------- > > > This is a follow up for Issue 1534: > https://issues.apache.org/jira/browse/SHINDIG-1534 > > > As discussed, default AuthorityProvider would implement following logic > with a Provider pattern > > 1. shindig.host & shindig.port defined in web.xml or system property > 2. host/port from HttpServletRequest > 3. Jetty host/port > > link to JIRA: https://issues.apache.org/jira/browse/SHINDIG-1541 > > > > Diffs (updated) > ----- > > http://svn.apache.org/repos/asf/shindig/trunk/config/container.js 1127686 > > > http://svn.apache.org/repos/asf/shindig/trunk/java/common/src/main/java/org/apache/shindig/common/PropertiesModule.java > 1127686 > > > http://svn.apache.org/repos/asf/shindig/trunk/java/common/src/main/java/org/apache/shindig/common/servlet/Authority.java > PRE-CREATION > > > http://svn.apache.org/repos/asf/shindig/trunk/java/common/src/main/java/org/apache/shindig/common/servlet/BasicAuthority.java > PRE-CREATION > > > http://svn.apache.org/repos/asf/shindig/trunk/java/common/src/main/java/org/apache/shindig/common/servlet/BasicAuthorityProvider.java > PRE-CREATION > > > http://svn.apache.org/repos/asf/shindig/trunk/java/common/src/main/java/org/apache/shindig/common/servlet/ServletRequestContext.java > 1127686 > > > http://svn.apache.org/repos/asf/shindig/trunk/java/common/src/test/java/org/apache/shindig/common/servlet/BasicAuthorityProviderTest.java > PRE-CREATION > > > http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/DefaultGuiceModule.java > 1127686 > > > http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/uri/DefaultConcatUriManager.java > 1127686 > > > http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/uri/DefaultIframeUriManager.java > 1127686 > > > http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/uri/DefaultJsUriManager.java > 1127686 > > > http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/uri/DefaultProxyUriManager.java > 1127686 > > > http://svn.apache.org/repos/asf/shindig/trunk/java/server/src/main/webapp/WEB-INF/web.xml > 1127686 > > > Diff: https://reviews.apache.org/r/792/diff > > > > Testing > ------- > > built, passed unit tests. tested with > /samplecontainer/examples/commoncontainer/index.html > > > Thanks, > > li > > > >
