Done. Also I came up with a another patch which would be much appropriate.I had use that in the review.
Link to the review : https://reviews.apache.org/r/1029/ On Wed, Jul 6, 2011 at 7:31 PM, Ryan J Baxter <rjbax...@us.ibm.com> wrote: > Could you please create a code review request using the Apache code review > tool? > https://reviews.apache.org/dashboard/ > > Make sure to add the dev list as a reviewer and it will send out a code > review request to the dev list. > > -Ryan > > Email: rjbax...@us.ibm.com > Phone: 978-899-3041 > developerWorks Profile > > > > From: Sumedha Sanjeewa <sumed...@wso2.com> > To: dev@shindig.apache.org, > Date: 07/05/2011 06:06 AM > Subject: Re: OAuth Error with Shindig > > > > Hi, > > I created an issue and attached the patch with it [1]. Please have a look > at > it. > > [1] https://issues.apache.org/jira/browse/SHINDIG-1556 > > On Tue, Jul 5, 2011 at 12:00 PM, Jasha Joachimsthal < > j.joachimst...@onehippo.com> wrote: > > > You can also create your own module (like > CommonContainerAuthGuiceModule) > > that does > > bind(SecurityTokenCodec.class).to(DefaultSecurityTokenCodec.class); > > This DefaultSecurityTokenCodec returns a BasicSecurityTokenCodec (or > > BlobCrypterSecurityTokenCodec if you're using secure). > > > > Jasha Joachimsthal > > > > Europe - Amsterdam - Oosteinde 11, 1017 WT Amsterdam - +31(0)20 522 4466 > > US - Boston - 1 Broadway, Cambridge, MA 02142 - +1 877 414 4776 (toll > > free) > > > > www.onehippo.com > > > > > > On 5 July 2011 08:08, Sumedha Sanjeewa <sumed...@wso2.com> wrote: > > > > > Hi, > > > > > > I was able to fix the problem. What I did was changing the method > > > createToken() in the CommonContainerSecurityTokenCodec class. In the > > trunk > > > it is implemented as > > > > > > public SecurityToken createToken(Map<String, String> > > > tokenParameters)throws SecurityTokenException { > > > > > > > > > TestSecurityTokenCodec testSecurityToken = new > > TestSecurityTokenCodec(); > > > return testSecurityToken; > > > > > > } > > > > > > I changed the method to use BasicSecurityTokenCodec instead of > > > TestSecurityTokenCodec. > > > i.e > > > > > > public SecurityToken createToken(Map<String, String> > > > tokenParameters)throws > > > SecurityTokenException { > > > > > > BasicSecurityTokenCodec basicSecurityTokenCodec = new > > > BasicSecurityTokenCodec(); > > > return basicSecurityTokenCodec.createToken(tokenParameters); > > > > > > } > > > > > > When I was debugging the code I noticed that the security token was > not > > > passed in the fetch method in OAuthRequest class. When I traced this > and > > > compared with Shindig 2.0.0, I found that current revision uses the > > > TestSecurityTokenCodec > > > instead of BasicSecurityTokenCodec. > > > > > > So after the above modification It worked fine and all the other > > > modifications I had mentioned in the above reply's are not needed. > This > > is > > > the only place that has to be modified. > > > > > > So is this modification correct..?? > > > > > > Thanks for your help guys.... > > > > > > > > > On Mon, Jul 4, 2011 at 8:21 PM, Evgeny Bogdanov > <evgeny.bogda...@epfl.ch > > > >wrote: > > > > > > > I suggest you create your own keys (at least that's what i did). The > > ones > > > > in the example > > > > might not work anymore (expired or something ...) > > > > > > > > > > > > On 04.07.11 15:18, Sumedha Sanjeewa wrote: > > > > > > > >> No. They are from the example. BTW I noticed that in the above > error > > my > > > * > > > >> oauth_signature_method="RSA-**SHA1"*. > > > >> But In the oauth.json the key type is set as *RSA-PRIVATE*. > > > >> Is this related to the error I'm getting. > > > >> > > > >> > > > >> > > > > > > > > > -- > > > Regards, > > > Sumedha Kodithuwakku > > > (SumedhaS) > > > > > > > > > -- > Regards, > Sumedha Kodithuwakku > (SumedhaS) > > > > -- Regards, Sumedha Kodithuwakku (SumedhaS)
