----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1190/#review1183 -----------------------------------------------------------
http://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/examples/media-openGadgets/MediaUIOpenGadgets.js <https://reviews.apache.org/r/1190/#comment2538> Add some comments here that your just demonstrating using this API, it does not server any real surpose. http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/open-views/viewenhancements-container.js <https://reviews.apache.org/r/1190/#comment2537> Small nit, please put brackets around the if else here, it will make it easier to read. - Ryan On 2011-07-25 22:09:04, Jason Chiang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/1190/ > ----------------------------------------------------------- > > (Updated 2011-07-25 22:09:04) > > > Review request for shindig and Ryan Baxter. > > > Summary > ------- > > > 1. Update implementation of gadgets.window.getContainerDimensions based on > latest API which will call the callback function with the dimension object as > parameter. > 2. correct the feature signature/docs. > > > Diffs > ----- > > > http://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/examples/media-openGadgets/MediaUIOpenGadgets.js > 1150846 > > http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/open-views/viewenhancements-container.js > 1150848 > > http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/open-views/viewenhancements.js > 1150848 > > http://svn.apache.org/repos/asf/shindig/trunk/features/src/test/javascript/features/open-views/viewEnhancements-test.js > 1150704 > > Diff: https://reviews.apache.org/r/1190/diff > > > Testing > ------- > > > Thanks, > > Jason > >
