----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1190/ -----------------------------------------------------------
(Updated 2011-07-26 14:23:13.290411) Review request for shindig and Ryan Baxter. Changes ------- new patch based on Ryan's feedback, thanks. Summary ------- 1. Update implementation of gadgets.window.getContainerDimensions based on latest API which will call the callback function with the dimension object as parameter. 2. correct the feature signature/docs. Diffs (updated) ----- http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/open-views/viewenhancements-container.js 1150848 http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/open-views/viewenhancements.js 1150848 http://svn.apache.org/repos/asf/shindig/trunk/features/src/test/javascript/features/open-views/viewEnhancements-test.js 1150704 http://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/examples/media-openGadgets/MediaUIOpenGadgets.js 1150846 Diff: https://reviews.apache.org/r/1190/diff Testing ------- Thanks, Jason
