----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1689/ -----------------------------------------------------------
(Updated 2011-08-31 22:12:15.636913) Review request for shindig, Ryan Baxter and Stanton Sievers. Changes ------- Updating from feedback from Ryan and Stanton. Summary ------- Specification: http://code.google.com/p/opensocial-resources/issues/detail?id=1210 Add 2 functions to the actions feature. 1 to allow the container to register a listener for an action being run. The listener would be run whenever an action matching the id provided was run. 1 to allow the container to unregister(remove) any listener added with the previous function. This addresses bug SHINDIG-1612. https://issues.apache.org/jira/browse/SHINDIG-1612 Diffs (updated) ----- http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/actions/actions_container.js 1163664 Diff: https://reviews.apache.org/r/1689/diff Testing ------- If anyone has any suggestions as to how to approach adding unit tests for this, I'm all ears. It looks like that in order to get the actions api to hit this code, by calling runAction, I'd need to somehow fake setting up a gadget site and register a fake action. Thanks, Dan
