> On 2011-08-31 21:09:46, Ryan Baxter wrote: > > http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/actions/actions_container.js, > > line 427 > > <https://reviews.apache.org/r/1682/diff/3/?file=36312#file36312line427> > > > > check that gadgetSites is not undefined
Ahh, thank you for catching that. - Dan ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1682/#review1704 ----------------------------------------------------------- On 2011-08-31 19:09:24, Dan Dumont wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/1682/ > ----------------------------------------------------------- > > (Updated 2011-08-31 19:09:24) > > > Review request for shindig, Ryan Baxter, Matthew Hatem, and Stanton Sievers. > > > Summary > ------- > > It looks like the current impl of declarative actions pick the first gadget > site where the URL matches and fires the action in that. The actions spec > lets you specify a target view, so we should make sure to check if the site > has that view rendered. It may also be rendered more than once, so we > should fire the action in all of them. > > > This addresses bug SHINDIG-1607. > https://issues.apache.org/jira/browse/SHINDIG-1607 > > > Diffs > ----- > > > http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/actions/actions_container.js > 1161182 > > Diff: https://reviews.apache.org/r/1682/diff > > > Testing > ------- > > > Thanks, > > Dan > >
