-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1682/
-----------------------------------------------------------
(Updated 2011-09-02 13:19:47.959759)
Review request for shindig, Ryan Baxter, Matthew Hatem, and Stanton Sievers.
Changes
-------
Now that actions have been fixed, the voip gadget was broken because it was
declaring an action with a view target it did not have.
Removing the view attribute on the declared actions solved the issue Ryan was
seeing.
Summary
-------
It looks like the current impl of declarative actions pick the first gadget
site where the URL matches and fires the action in that. The actions spec lets
you specify a target view, so we should make sure to check if the site has that
view rendered. It may also be rendered more than once, so we should fire the
action in all of them.
This addresses bug SHINDIG-1607.
https://issues.apache.org/jira/browse/SHINDIG-1607
Diffs (updated)
-----
http://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/examples/conservcontainer/sample-actions-voip.xml
1163664
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/actions/actions_container.js
1163664
Diff: https://reviews.apache.org/r/1682/diff
Testing
-------
Thanks,
Dan
