----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2333/ -----------------------------------------------------------
(Updated 2011-10-12 16:11:47.242307) Review request for shindig, Ryan Baxter and Dan Dumont. Changes ------- Adding the larger dev list audience Summary ------- The proposed changes are to introduce an abstract class that implements LockedDomainService and provides some infrastructure to make creating one's own LockedDomainService a bit easier. Sorry for the horrible diffs. I moved a lot of stuff around in HashLockedDomainService. This addresses bug SHINDIG-1637. https://issues.apache.org/jira/browse/SHINDIG-1637 Diffs ----- http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/AbstractLockedDomainService.java PRE-CREATION http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/HashLockedDomainService.java 1181021 http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/LockedDomainService.java 1181021 http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/HashLockedDomainServiceTest.java 1181021 http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/render/RendererTest.java 1181021 Diff: https://reviews.apache.org/r/2333/diff Testing ------- Updated and ran existing JUnits. Thanks, Stanton