----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2404/#review2658 -----------------------------------------------------------
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/actions/actions_container.js <https://reviews.apache.org/r/2404/#comment5978> There's some whitespace at the end here, could you remove it? - Dan On 2011-10-18 15:32:30, Jason Chiang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/2404/ > ----------------------------------------------------------- > > (Updated 2011-10-18 15:32:30) > > > Review request for shindig, Ryan Baxter and Matthew Hatem. > > > Summary > ------- > > Declarative action does not work on IE. > 1. The Declarative actions will be show undefined > 2. Cannot run the actions > > Link to jira https://issues.apache.org/jira/browse/SHINDIG-1642 > > > Diffs > ----- > > > http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/actions/actions.js > 1185711 > > http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/actions/actions_container.js > 1185711 > > Diff: https://reviews.apache.org/r/2404/diff > > > Testing > ------- > > Test done on sample container with sample voip gadget on IE8, also passed > jsUnit test. > > > Thanks, > > Jason > >