----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2404/#review2674 -----------------------------------------------------------
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/actions/actions.js <https://reviews.apache.org/r/2404/#comment6025> Just a nit, but I would do callback.apply(this, selectionObj ? [selectionObj] : []); http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/actions/actions_container.js <https://reviews.apache.org/r/2404/#comment6029> I wouldn't define a new function on the Object class, generally this isn't a good idea. http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/actions/actions_container.js <https://reviews.apache.org/r/2404/#comment6026> Don't iterate over array with for(var in object) syntax. It can be dangerous. http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/actions/actions_container.js <https://reviews.apache.org/r/2404/#comment6032> for(var i = 0, actionObj; actionObj = actions[i]; i++) { var delkeys = [], n = 0; for (var key in actionObj) { actionObj[key.substring(1)] = actionObj[delkeys[n++] = key]; } // Remove old keys. Can't do this in previous loop because IE gets // confused iterating over and modifying keys. for(var j = 0, key; key = delkeys[j]; j++) { delete actionObj[key]; } } - Dan On 2011-10-19 01:17:48, Jason Chiang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/2404/ > ----------------------------------------------------------- > > (Updated 2011-10-19 01:17:48) > > > Review request for shindig, Ryan Baxter and Matthew Hatem. > > > Summary > ------- > > Declarative action does not work on IE. > 1. The Declarative actions will be show undefined > 2. Cannot run the actions > > Link to jira https://issues.apache.org/jira/browse/SHINDIG-1642 > > > Diffs > ----- > > > http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/actions/actions_container.js > 1185865 > > http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/actions/actions.js > 1185857 > > Diff: https://reviews.apache.org/r/2404/diff > > > Testing > ------- > > Test done on sample container with sample voip gadget on IE8, also passed > jsUnit test. > > > Thanks, > > Jason > >
