----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2824/ -----------------------------------------------------------
(Updated 2011-11-14 20:46:51.179593)
Review request for shindig.
Changes
-------
Updated patch based on feedback.
Summary
-------
Update the ContainerConfig stack to allow for res://some-resource.txt and
file:///some-file.txt style values in container.js and automatically resolve
these references during initialization. This allows us to refactor
BlobCrypterSecurityTokenCodec to expect to be given the actual encryption key
rather than a key or resource pointer as it does currently.
This also opens the door for this functionality to be used for other
configuration which we'd like to load from external files (which should be
useful for third party implementers).
This addresses bug shindig-1660.
https://issues.apache.org/jira/browse/shindig-1660
Diffs (updated)
-----
http://svn.apache.org/repos/asf/shindig/trunk/config/container.js 1201745
http://svn.apache.org/repos/asf/shindig/trunk/java/common/src/main/java/org/apache/shindig/auth/BlobCrypterSecurityTokenCodec.java
1201745
http://svn.apache.org/repos/asf/shindig/trunk/java/common/src/main/java/org/apache/shindig/auth/DefaultSecurityTokenCodec.java
1201745
http://svn.apache.org/repos/asf/shindig/trunk/java/common/src/main/java/org/apache/shindig/common/util/ResourceLoader.java
1201745
http://svn.apache.org/repos/asf/shindig/trunk/java/common/src/main/java/org/apache/shindig/config/JsonContainerConfigLoader.java
1201745
http://svn.apache.org/repos/asf/shindig/trunk/java/common/src/test/java/org/apache/shindig/auth/BlobCrypterSecurityTokenCodecTest.java
1201745
http://svn.apache.org/repos/asf/shindig/trunk/java/common/src/test/java/org/apache/shindig/auth/DefaultSecurityTokenCodecTest.java
1201745
http://svn.apache.org/repos/asf/shindig/trunk/java/common/src/test/java/org/apache/shindig/config/JsonContainerConfigLoaderTest.java
1201745
http://svn.apache.org/repos/asf/shindig/trunk/java/common/src/test/resources/classpath-accessible-test-file.txt
PRE-CREATION
Diff: https://reviews.apache.org/r/2824/diff
Testing
-------
Updated/added tests. Ran build, verified unit tests and tested common
container.
Thanks,
Jesse
