> On 2011-11-14 19:26:13, Henry Saputra wrote: > > http://svn.apache.org/repos/asf/shindig/trunk/java/common/src/test/java/org/apache/shindig/auth/BlobCrypterSecurityTokenCodecTest.java, > > line 230 > > <https://reviews.apache.org/r/2824/diff/1/?file=57912#file57912line230> > > > > Can we add fail test for the new methods?
That test was there because the BlobCrypterSecurityTokenCodec used to handle reading in the security token key from an external resource (file or classpath resource) but that work is now handled by the ContainerConfig loader -- I'll go ahead and add a couple failure tests there too though. - Jesse ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2824/#review3213 ----------------------------------------------------------- On 2011-11-14 20:46:51, Jesse Ciancetta wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/2824/ > ----------------------------------------------------------- > > (Updated 2011-11-14 20:46:51) > > > Review request for shindig. > > > Summary > ------- > > Update the ContainerConfig stack to allow for res://some-resource.txt and > file:///some-file.txt style values in container.js and automatically resolve > these references during initialization. This allows us to refactor > BlobCrypterSecurityTokenCodec to expect to be given the actual encryption key > rather than a key or resource pointer as it does currently. > > This also opens the door for this functionality to be used for other > configuration which we'd like to load from external files (which should be > useful for third party implementers). > > > This addresses bug shindig-1660. > https://issues.apache.org/jira/browse/shindig-1660 > > > Diffs > ----- > > http://svn.apache.org/repos/asf/shindig/trunk/config/container.js 1201745 > > http://svn.apache.org/repos/asf/shindig/trunk/java/common/src/main/java/org/apache/shindig/auth/BlobCrypterSecurityTokenCodec.java > 1201745 > > http://svn.apache.org/repos/asf/shindig/trunk/java/common/src/main/java/org/apache/shindig/auth/DefaultSecurityTokenCodec.java > 1201745 > > http://svn.apache.org/repos/asf/shindig/trunk/java/common/src/main/java/org/apache/shindig/common/util/ResourceLoader.java > 1201745 > > http://svn.apache.org/repos/asf/shindig/trunk/java/common/src/main/java/org/apache/shindig/config/JsonContainerConfigLoader.java > 1201745 > > http://svn.apache.org/repos/asf/shindig/trunk/java/common/src/test/java/org/apache/shindig/auth/BlobCrypterSecurityTokenCodecTest.java > 1201745 > > http://svn.apache.org/repos/asf/shindig/trunk/java/common/src/test/java/org/apache/shindig/auth/DefaultSecurityTokenCodecTest.java > 1201745 > > http://svn.apache.org/repos/asf/shindig/trunk/java/common/src/test/java/org/apache/shindig/config/JsonContainerConfigLoaderTest.java > 1201745 > > http://svn.apache.org/repos/asf/shindig/trunk/java/common/src/test/resources/classpath-accessible-test-file.txt > PRE-CREATION > > Diff: https://reviews.apache.org/r/2824/diff > > > Testing > ------- > > Updated/added tests. Ran build, verified unit tests and tested common > container. > > > Thanks, > > Jesse > >
