----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2950/#review3543 -----------------------------------------------------------
http://svn.apache.org/repos/asf/shindig/trunk/config/container.js <https://reviews.apache.org/r/2950/#comment7879> I dont think I see this anywhere in the updated changes -- is it just not being used anywhere? http://svn.apache.org/repos/asf/shindig/trunk/config/container.js <https://reviews.apache.org/r/2950/#comment7878> All of the "default.domain.*" properties look new to me and I cant find any reference to them in the current codebase -- are those supposed to be added as part of this cleanup? - Jesse On 2011-11-28 20:27:24, Dan Dumont wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/2950/ > ----------------------------------------------------------- > > (Updated 2011-11-28 20:27:24) > > > Review request for shindig, Ryan Baxter and Stanton Sievers. > > > Summary > ------- > > I've attempted to make it a little easier for people to enable locked domains > by clarifying some comments and marking critical configuration sections. > > Please, if I've misinterpreted or misrepresented a config setting, let me > know. > > Will attach a JIRA if necessary. I did want some comments before submitting > something like this though. > > > Diffs > ----- > > http://svn.apache.org/repos/asf/shindig/trunk/config/container.js 1207269 > > Diff: https://reviews.apache.org/r/2950/diff > > > Testing > ------- > > All tests pass. > > > Thanks, > > Dan > >