> On 2011-11-28 21:20:14, Jesse Ciancetta wrote: > > http://svn.apache.org/repos/asf/shindig/trunk/config/container.js, line 86 > > <https://reviews.apache.org/r/2950/diff/1/?file=60293#file60293line86> > > > > I dont think I see this anywhere in the updated changes -- is it just > > not being used anywhere?
I didn't see any references. It looks like it might be used by a client side script loader, but google has not contributed theirs (yet?), so I don't think it's being used. > On 2011-11-28 21:20:14, Jesse Ciancetta wrote: > > http://svn.apache.org/repos/asf/shindig/trunk/config/container.js, line 120 > > <https://reviews.apache.org/r/2950/diff/1/?file=60293#file60293line120> > > > > All of the "default.domain.*" properties look new to me and I cant find > > any reference to them in the current codebase -- are those supposed to be > > added as part of this cleanup? These aren't used in the source code. They are referenced by other properties below them. The container lets you use expressions to refer to other variables. Since I've had to change several properties to get locked domains working, I figured referring them all to 1 value might make someone's life easier. - Dan ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2950/#review3543 ----------------------------------------------------------- On 2011-11-28 20:27:24, Dan Dumont wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/2950/ > ----------------------------------------------------------- > > (Updated 2011-11-28 20:27:24) > > > Review request for shindig, Ryan Baxter and Stanton Sievers. > > > Summary > ------- > > I've attempted to make it a little easier for people to enable locked domains > by clarifying some comments and marking critical configuration sections. > > Please, if I've misinterpreted or misrepresented a config setting, let me > know. > > Will attach a JIRA if necessary. I did want some comments before submitting > something like this though. > > > Diffs > ----- > > http://svn.apache.org/repos/asf/shindig/trunk/config/container.js 1207269 > > Diff: https://reviews.apache.org/r/2950/diff > > > Testing > ------- > > All tests pass. > > > Thanks, > > Dan > >
