----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3566/#review4496 -----------------------------------------------------------
Ship it! LGTM. Thanks Henry! To clarify, is this only an issue in IE7 or would it be an issue with any browser that uses the flash transport? Theoretically you could force RPC to always use flash, regardless of the browser, by setting rpctx=flash in the query params. See rpc.js#getTransport() trunk/features/src/main/javascript/features/rpc/flash.transport.js <https://reviews.apache.org/r/3566/#comment10086> Out of curiosity, how did you come up with this number? - Stanton On 2012-01-20 16:53:37, Henry Saputra wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/3566/ > ----------------------------------------------------------- > > (Updated 2012-01-20 16:53:37) > > > Review request for shindig and johnfargo. > > > Summary > ------- > > See "SHINDIG-1678 The flash transport to support RPC for IE7 has problem with > multiple gadgets in a single container" > https://issues.apache.org/jira/browse/SHINDIG-1678 for detail description > about the review. > > Proposed fix is to flush the handshakes objects whenever new gadgets call > gadgets.rpc.setupReceiver is called to make sure the container side register > the child iframe info to the flash component. > > > This addresses bug SHINDIG-1678. > https://issues.apache.org/jira/browse/SHINDIG-1678 > > > Diffs > ----- > > trunk/features/src/main/javascript/features/rpc/flash.transport.js 1233272 > > Diff: https://reviews.apache.org/r/3566/diff > > > Testing > ------- > > Running multiple gadgets in common container in IE7 > > > Thanks, > > Henry > >
