----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3908/#review5123 -----------------------------------------------------------
Could you please provide a bit more information on the use case that you are trying and what's going on? I want to make sure I understand this before I review. Also, there's a bunch of whitespace that needs to be cleaned up. Please remove all trailing line whitespace =~/[ \t]+$//; (if you'll forgive my perl) Also, please use tab = 2 spaces + convert tabs to spaces. - Dan On 2012-02-15 04:09:39, Yao Zhang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/3908/ > ----------------------------------------------------------- > > (Updated 2012-02-15 04:09:39) > > > Review request for shindig, Henry Saputra, li xu, Dan Dumont, and Stanton > Sievers. > > > Summary > ------- > > When you try to render a gadget to a dom node inside an existing iframe, rpc > does not work as the code is using document.getElementById to get the domnode > > > This addresses bug SHINDIG-1704. > https://issues.apache.org/jira/browse/SHINDIG-1704 > > > Diffs > ----- > > > http://svn.apache.org/repos/asf/shindig/trunk/extras/src/main/javascript/features-extras/org.openajax.hub-2.0.5/iframe.js > 1238149 > > http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/rpc/rpc.js > 1238149 > > Diff: https://reviews.apache.org/r/3908/diff > > > Testing > ------- > > > Thanks, > > Yao > >
