----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3908/#review8743 -----------------------------------------------------------
Can you look at adding some JUnits around this functionality? I'm always concerned about breaking RPC, since it is at the core of basically everything that happens client-side. The rest is mostly comments on style. http://svn.apache.org/repos/asf/shindig/trunk/extras/src/main/javascript/features-extras/org.openajax.hub-2.0.5/iframe.js <https://reviews.apache.org/r/3908/#comment18441> Nit on whitespace and use of tabs instead of spaces. http://svn.apache.org/repos/asf/shindig/trunk/extras/src/main/javascript/features-extras/org.openajax.hub-2.0.5/iframe.js <https://reviews.apache.org/r/3908/#comment18442> Nite on trailing whitespace http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container.site.gadget/gadget_holder.js <https://reviews.apache.org/r/3908/#comment18443> Nit on tabs instead of spaces http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container.site.gadget/gadget_holder.js <https://reviews.apache.org/r/3908/#comment18444> Nit on whitespace http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/rpc/rpc.js <https://reviews.apache.org/r/3908/#comment18445> Nit on tabs instead of spaces http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/rpc/rpc.js <https://reviews.apache.org/r/3908/#comment18446> Nit on tabs instead of spaces. - Stanton Sievers On March 19, 2012, 7:38 a.m., Yao Zhang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/3908/ > ----------------------------------------------------------- > > (Updated March 19, 2012, 7:38 a.m.) > > > Review request for shindig, Henry Saputra, li xu, Dan Dumont, and Stanton > Sievers. > > > Description > ------- > > When you try to render a gadget to a dom node inside an existing iframe, rpc > does not work as the code is using document.getElementById to get the domnode > > > This addresses bug SHINDIG-1704. > https://issues.apache.org/jira/browse/SHINDIG-1704 > > > Diffs > ----- > > > http://svn.apache.org/repos/asf/shindig/trunk/extras/src/main/javascript/features-extras/org.openajax.hub-2.0.5/iframe.js > 1299960 > > http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container.site.gadget/gadget_holder.js > 1299960 > > http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/rpc/rpc.js > 1299960 > > Diff: https://reviews.apache.org/r/3908/diff/ > > > Testing > ------- > > > Thanks, > > Yao Zhang > >
