Sweet! Thanks Mike
On Thursday, March 8, 2012, Michael S May <ms...@us.ibm.com> wrote: > Henry, > > I am already working on a fix. I'll keep you updated and reach out if I > need any help! > > Thanks! > -- > Mike May > > > > From: Henry Saputra <henry.sapu...@gmail.com> > To: dev@shindig.apache.org, > Date: 03/07/2012 02:42 PM > Subject: Re: osapi.groups missing > > > > Yeah, its a good idea. I think the Group is missing due to some > discussions long back about how Groups specs will be updated. > > I will take a stab at it next week if no one volunteer to do this. > > - Henry > > On Tue, Mar 6, 2012 at 3:42 AM, Stanton Sievers <ssiev...@us.ibm.com> > wrote: >> That's exactly it Henry. No one is binding GroupService or implementing >> it. Shindig simply doesn't have a GroupService implementation. The >> simplest solution may be to have JsonDbOpensocialService implement >> GroupService and then have SampleModule bind it like it does everything >> else. >> >> Even if the implementation of the GroupService APIs throws >> UnsupportedOperationException, I think it's good to have it "wired up" > so >> that implementers have a good idea of all of the handlers and services >> they need to provide and bind, respectively. The real goal would be to >> implement it against the canonicaldb.json and also as a stretch > implement >> it in the JPASocialModule like we do for person, activity, and app data. >> >> What do you think? >> >> Thanks, >> -Stanton >> >> >> >> From: Henry Saputra <henry.sapu...@gmail.com> >> To: dev@shindig.apache.org, >> Date: 03/05/2012 21:45 >> Subject: Re: osapi.groups missing >> >> >> >> Hmm its probably because the GroupService API is not implemented in >> the JsonDbOpensocialService that cause Guice injection to fail? >> >> - Henry >> >> On Mon, Mar 5, 2012 at 2:13 PM, Stanton Sievers <ssiev...@us.ibm.com> >> wrote: >>> I see the same thing in trunk, Henry. >>> >>> protected Set<Class<?>> getHandlers() { >>> return ImmutableSet.of(ActivityHandler.class, AppDataHandler.class, >>> PersonHandler.class, MessageHandler.class, >> AlbumHandler.class, >>> MediaItemHandler.class, ActivityStreamHandler.class); >>> } >>> >>> No GroupHandler in there. And actually, zero refs to GroupHandler at > all >>> according to Eclipse. :( >>> >>> Thanks, >>> -Stanton >>> >>> >>> >>> From: Henry Saputra <henry.sapu...@gmail.com> >>> To: dev@shindig.apache.org, >>> Date: 03/05/2012 16:55 >>> Subject: Re: osapi.groups missing >>> >>> >>> >>> Are you running against trunk? >>> >>> - Henry >>> >>> On Mon, Mar 5, 2012 at 12:32 PM, Misty May <themisty...@gmail.com> >> wrote: >>>> Hello all, >>>> >>>> So it turnes out that groups is missing from the osapi namespace. Is >>> there >>>> any reason for this or is this a bug? >>>> >>>> Running under the assumption it was a bug, I searched for a solution. >>>> Turns out that the SocialApiGuiceModule fails to include the >>> GroupHandler >>>> when getting handlers. However when I added the GroupHandler tests >>> started >>>> failing. Any ideas? >>>> >>>> If this should not be happening I will investigate the failing tests >>>> further but I wanted to clear these few questions up first. >>>> >>>> Regards, >>>> Mike >>> >>> >> >> > > >