-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4247/
-----------------------------------------------------------

Review request for shindig.


Summary
-------

Remove osapi.container.util.warn because it only serves to cause issues in IE.  
Replace it with gadgets.warn instead.


This addresses bug SHINDIG-1725.
    https://issues.apache.org/jira/browse/SHINDIG-1725


Diffs
-----

  
http://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/examples/commoncontainer/index.html
 1298060 
  
http://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/examples/commoncontainer/viewController.js
 1298060 
  
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container.site.gadget/gadget_site.js
 1298060 
  
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container.util/util.js
 1298060 
  
http://svn.apache.org/repos/asf/shindig/trunk/features/src/test/javascript/features/container/gadget_site_test.js
 1298060 

Diff: https://reviews.apache.org/r/4247/diff


Testing
-------

Modified the sample common container to allow me to hit the code paths I'm 
testing.  These changes are part of the patch and I can drop them if we really 
don't want them going back to Shindig.


Thanks,

Stanton

Reply via email to