----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5067/#review7731 -----------------------------------------------------------
To be honest, your code changes make my head hurt. However, I applied the patch and was playing around with it in the sample common container page with the gadget you provided. I noticed that if I click the "fit-width" button, the "fit-height" button actually wraps onto a new line in FF12. fit-height seems to work just fine. Also, if I change the "dir" on the body to "rtl", fit-width seems to have no effect and "skinny" just hoses the gadget - I lose my vertical scroll bar and can't find the buttons. http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/dynamic-size.util/dynamic-size-util.js <https://reviews.apache.org/r/5067/#comment17028> Don't you mean rtl? :) - Stanton On 2012-05-08 19:29:37, Dan Dumont wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/5067/ > ----------------------------------------------------------- > > (Updated 2012-05-08 19:29:37) > > > Review request for shindig. > > > Summary > ------- > > With the latest changes from > https://issues.apache.org/jira/browse/SHINDIG-1766, the auto adjust of > dynamic-height and dynamic-width features was broken. > > The webkit height calculation is now the most reliable means of obtaining the > content height/width of the gadget in every browser I've tested, so I cleaned > that up for either height or width and moved it to the common feature. > > > This addresses bug SHINDIG-1767. > https://issues.apache.org/jira/browse/SHINDIG-1767 > > > Diffs > ----- > > > http://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/examples/DynamicSizeDemoHTML5.xml > PRE-CREATION > > http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/dynamic-height.height/dynamic-height-height.js > 1333997 > > http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/dynamic-size.util/dynamic-size-util.js > 1333997 > > http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/dynamic-size.util/feature.xml > 1333997 > > http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/dynamic-width.width/dynamic-width-width.js > 1333997 > > http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/dynamic-width/dynamic-width.js > 1333997 > > Diff: https://reviews.apache.org/r/5067/diff > > > Testing > ------- > > Tested in IE 7,8,9 Chrome, FF using quirks and html5 > > > Thanks, > > Dan > >
