----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5067/ -----------------------------------------------------------
(Updated 2012-05-09 14:46:39.840885) Review request for shindig. Changes ------- I think this should fix the rtl/ltr issues Stanton ran in to. Summary ------- With the latest changes from https://issues.apache.org/jira/browse/SHINDIG-1766, the auto adjust of dynamic-height and dynamic-width features was broken. The webkit height calculation is now the most reliable means of obtaining the content height/width of the gadget in every browser I've tested, so I cleaned that up for either height or width and moved it to the common feature. This addresses bug SHINDIG-1767. https://issues.apache.org/jira/browse/SHINDIG-1767 Diffs (updated) ----- http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/dynamic-size.util/dynamic-size-util.js 1333997 http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/dynamic-size.util/feature.xml 1333997 http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/dynamic-width.width/dynamic-width-width.js 1333997 http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/dynamic-width/dynamic-width.js 1333997 http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/dynamic-height.height/dynamic-height-height.js 1333997 http://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/examples/DynamicSizeDemoHTML5.xml PRE-CREATION http://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/examples/DynamicSizeDemo.xml 1333997 Diff: https://reviews.apache.org/r/5067/diff Testing ------- Tested in IE 7,8,9 Chrome, FF using quirks and html5 Thanks, Dan
