> On 2012-05-10 17:00:08, Stanton Sievers wrote: > > Please take a look at https://issues.apache.org/jira/browse/SHINDIG-1533. > > It tried to address this issue earlier by allowing one to define a window > > global to specify the ID of the script tag. > > > > Mike May wrote: > That functionality remains. This code adds the logic to try and find the > correct script if the window global id is not defined. I can see an > implementer not realizing the id needed to be define when they include > Javascript below the JSservlet URL.
Without being able to read the config, this approach is going to be limited, I think. The JsServlet endpoint is configurable in container.js via "gadgets.uri.js.path". If a deployer of Shindig changes that configuration, this code no longer works. If we're fine with this being a "best effort" approach and then the __CONTAINER_SCRIPT_ID being the "catch all", then I think this approach is OK. - Stanton ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5087/#review7777 ----------------------------------------------------------- On 2012-05-10 16:46:50, Mike May wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/5087/ > ----------------------------------------------------------- > > (Updated 2012-05-10 16:46:50) > > > Review request for shindig, Ryan Baxter, Dan Dumont, and Stanton Sievers. > > > Summary > ------- > > init.js assumes the feature URL for the JS servlet is the last script tag > when this will not always be the case. > > > This addresses bug SHINDIG-1774. > https://issues.apache.org/jira/browse/SHINDIG-1774 > > > Diffs > ----- > > > http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container/init.js > 1336780 > > Diff: https://reviews.apache.org/r/5087/diff > > > Testing > ------- > > All tests pass. > > Local testing done. > > > Thanks, > > Mike > >
