----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5087/#review7788 -----------------------------------------------------------
Ship it! LGTM - Ryan On 2012-05-10 16:46:50, Mike May wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/5087/ > ----------------------------------------------------------- > > (Updated 2012-05-10 16:46:50) > > > Review request for shindig, Ryan Baxter, Dan Dumont, and Stanton Sievers. > > > Summary > ------- > > init.js assumes the feature URL for the JS servlet is the last script tag > when this will not always be the case. > > > This addresses bug SHINDIG-1774. > https://issues.apache.org/jira/browse/SHINDIG-1774 > > > Diffs > ----- > > > http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container/init.js > 1336780 > > Diff: https://reviews.apache.org/r/5087/diff > > > Testing > ------- > > All tests pass. > > Local testing done. > > > Thanks, > > Mike > >
