----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5420/#review8395 -----------------------------------------------------------
Adam I noticed we are lacking some unit tests for this method (and most of the class in general). This might be a good opportunity to add some unit tests. - Ryan Baxter On June 19, 2012, 1:15 p.m., Adam Clarke wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/5420/ > ----------------------------------------------------------- > > (Updated June 19, 2012, 1:15 p.m.) > > > Review request for shindig, Stanton Sievers and Brian Lillie. > > > Description > ------- > > When looking up an OAuth2Accessor in a shared token scenario the gadgetUri > should be rewritten (like we do for token operations.) > > > This addresses bug SHINDIG-1801. > https://issues.apache.org/jira/browse/SHINDIG-1801 > > > Diffs > ----- > > > http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/BasicOAuth2Store.java > 1351704 > > Diff: https://reviews.apache.org/r/5420/diff/ > > > Testing > ------- > > All unit tests pass > > > Thanks, > > Adam Clarke > >
