> On June 19, 2012, 1:39 p.m., Dan Dumont wrote: > > http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/BasicOAuth2Store.java, > > line 182 > > <https://reviews.apache.org/r/5420/diff/1/?file=112210#file112210line182> > > > > Could you change this variable name to something more meaningful? > > > > Or perhaps just avoid it completely, and pass the get directly into the > > set.
Changed to processedGadgetUri - Adam ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5420/#review8387 ----------------------------------------------------------- On June 21, 2012, 3:53 p.m., Adam Clarke wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/5420/ > ----------------------------------------------------------- > > (Updated June 21, 2012, 3:53 p.m.) > > > Review request for shindig and Brian Lillie. > > > Description > ------- > > When looking up an OAuth2Accessor in a shared token scenario the gadgetUri > should be rewritten (like we do for token operations.) > > > This addresses bug SHINDIG-1801. > https://issues.apache.org/jira/browse/SHINDIG-1801 > > > Diffs > ----- > > > http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/BasicOAuth2Store.java > 1352576 > > Diff: https://reviews.apache.org/r/5420/diff/ > > > Testing > ------- > > All unit tests pass > > > Thanks, > > Adam Clarke > >
