> On July 8, 2012, 8:33 p.m., Stanton Sievers wrote: > > trunk/features/src/main/javascript/features/rpc/rpc.js, lines 440-443 > > <https://reviews.apache.org/r/5810/diff/1/?file=119906#file119906line440> > > > > Is this also going to cause an issue in the scenario you described? > > This is the only other use of window.top I see.
Good catch, I didnt see error when I test it but let me take a look again. - Henry ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5810/#review8953 ----------------------------------------------------------- On July 6, 2012, 6:11 p.m., Henry Saputra wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/5810/ > ----------------------------------------------------------- > > (Updated July 6, 2012, 6:11 p.m.) > > > Review request for shindig. > > > Description > ------- > > The Shindig container could be rendered inside parent iframe and in this > scenario, the rpc check for isChild (almost the same as check fro isGadget) > does not work well because its actually act as the real container even though > its put inside another iframe. > > The proposed fix to add check for url param "parent" as well as the check for > window instance. > > > Diffs > ----- > > trunk/features/src/main/javascript/features/rpc/rpc.js 1356941 > > Diff: https://reviews.apache.org/r/5810/diff/ > > > Testing > ------- > > Unit tests still pass. Common container renders gadgets and rpc works as > expected. > > > Thanks, > > Henry Saputra > >
