-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5810/
-----------------------------------------------------------
(Updated July 9, 2012, 6:59 p.m.)
Review request for shindig.
Description
-------
The Shindig container could be rendered inside parent iframe and in this
scenario, the rpc check for isChild (almost the same as check fro isGadget)
does not work well because its actually act as the real container even though
its put inside another iframe.
The proposed fix to add check for url param "parent" as well as the check for
window instance.
This addresses bug SHINDIG-1816.
https://issues.apache.org/jira/browse/SHINDIG-1816
Diffs
-----
trunk/features/src/main/javascript/features/rpc/rpc.js 1356941
Diff: https://reviews.apache.org/r/5810/diff/
Testing
-------
Unit tests still pass. Common container renders gadgets and rpc works as
expected.
Thanks,
Henry Saputra
