----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/8184/#review14371 -----------------------------------------------------------
Ship it! Could you attach the current patch to the jira? - Dan Dumont On Dec. 7, 2012, 1:08 a.m., Zhi Hong Yang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/8184/ > ----------------------------------------------------------- > > (Updated Dec. 7, 2012, 1:08 a.m.) > > > Review request for shindig, Ryan Baxter, Dan Dumont, Stanton Sievers, and > Rich Thompson. > > > Description > ------- > > Copied from https://reviews.apache.org/r/6695/ > > The OpenSocial 2.0 specification now states that the old way of doing > variable subsitution is now deprecated in favor of using EL syntax. Add that > support to Shindig. > > > For example, Gadget developer should be able to to use EL syntax to > 1. Calculate value like ${1+2} > 2. get user preference values anywhere in the gadget XML by ${UserPrefs.xxx} > > > This addresses bug shindig-1588. > https://issues.apache.org/jira/browse/shindig-1588 > > > Diffs > ----- > > > http://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/examples/ELInGadgetDemo.xml > PRE-CREATION > > http://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/examples/commoncontainer/gadgetCollections.json > 1417305 > > http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/render/RenderingGadgetRewriter.java > 1417305 > > http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/templates/DefaultTemplateProcessor.java > 1417305 > > http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/render/RenderingGadgetRewriterTest.java > 1417305 > > http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/templates/DefaultTemplateProcessorTest.java > 1417305 > > Diff: https://reviews.apache.org/r/8184/diff/ > > > Testing > ------- > > Upload a Test Gadget with this patch > > > Thanks, > > Zhi Hong Yang > >
