----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9017/ -----------------------------------------------------------
(Updated Jan. 18, 2013, 8:55 a.m.) Review request for shindig, Ryan Baxter, Dan Dumont, Stanton Sievers, and Rich Thompson. Summary (updated) ----------------- PropertyNotFoundException handle(Variable Substitution should support EL syntax) Description (updated) ------- In https://reviews.apache.org/r/8184/ patch, there is a bug: When there is variable can not be resolved by shindig EL(i.e. ${notexist}), it will throw PropertyNotFoundException in gadget renderring and the gadget renderring will be failed. In this patch the exception will be ignored if the variable can not be resolved by shindig EL. This addresses bug shindig-1588. https://issues.apache.org/jira/browse/shindig-1588 Diffs ----- http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/render/RenderingGadgetRewriter.java 1435051 Diff: https://reviews.apache.org/r/9017/diff/ Testing ------- Thanks, Zhi Hong Yang