----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/8244/#review14912 -----------------------------------------------------------
Ship it! Ship It! - Ryan Baxter On Dec. 18, 2012, 7:22 a.m., Marshall Shi wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/8244/ > ----------------------------------------------------------- > > (Updated Dec. 18, 2012, 7:22 a.m.) > > > Review request for shindig, Ryan Baxter, Dan Dumont, Stanton Sievers, and > Rich Thompson. > > > Description > ------- > > swfobject feature is third party resource and is not used in any shindig core > features, propose to move it to extras. > > > This addresses bug SHINDIG-1887. > https://issues.apache.org/jira/browse/SHINDIG-1887 > > > Diffs > ----- > > http://svn.apache.org/repos/asf/shindig/trunk/extras/pom.xml 1401141 > > http://svn.apache.org/repos/asf/shindig/trunk/extras/src/main/appended-resources/META-INF/LICENSE > PRE-CREATION > > http://svn.apache.org/repos/asf/shindig/trunk/extras/src/main/javascript/features-extras/features.txt > 1374902 > > http://svn.apache.org/repos/asf/shindig/trunk/extras/src/main/javascript/features-extras/swfobject/feature.xml > PRE-CREATION > > http://svn.apache.org/repos/asf/shindig/trunk/extras/src/main/javascript/features-extras/swfobject/swfobject.js > PRE-CREATION > > http://svn.apache.org/repos/asf/shindig/trunk/extras/src/main/javascript/features-extras/swfobject/swfobject.opt.js > PRE-CREATION > http://svn.apache.org/repos/asf/shindig/trunk/features/pom.xml 1401141 > > http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/appended-resources/META-INF/LICENSE > 1373213 > > http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/features.txt > 1395438 > > http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/swfobject/feature.xml > 1383189 > > http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/swfobject/swfobject.js > 1383189 > > http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/swfobject/swfobject.opt.js > 1383189 > http://svn.apache.org/repos/asf/shindig/trunk/pom.xml 1406188 > > Diff: https://reviews.apache.org/r/8244/diff/ > > > Testing > ------- > > Done > > > Thanks, > > Marshall Shi > >
