> On Jan. 28, 2013, 5:53 a.m., Henry Saputra wrote: > > Hmm I remember there was an issue before to not forward user agent when > > proxying content. Could you try to find JIRA issue for it?
Hi Henry, JIRA 1781 is the one you are referring to. That patch deals with the MakeRequestHandler code path while this patch is for ProxyHandler. https://issues.apache.org/jira/browse/SHINDIG-1781 - Marshall ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/8951/#review15742 ----------------------------------------------------------- On Jan. 28, 2013, 4:51 a.m., Marshall Shi wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/8951/ > ----------------------------------------------------------- > > (Updated Jan. 28, 2013, 4:51 a.m.) > > > Review request for shindig, Ryan Baxter, Dan Dumont, Stanton Sievers, and > Rich Thompson. > > > Description > ------- > > The ProxyHandler currently does not forward the correct User-Agent to the > target server. We have certain cases that the target server needs to check > the User-Agent and decide the content of the response. > > > This addresses bug SHINDIG-1894. > https://issues.apache.org/jira/browse/SHINDIG-1894 > > > Diffs > ----- > > > http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/http/AbstractHttpCache.java > 1406188 > > http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/ProxyHandler.java > 1406188 > > http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/ProxyServlet.java > 1406188 > > http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/http/AbstractHttpCacheTest.java > 1406188 > > http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/render/ProxyRendererTest.java > 1406188 > > http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/servlet/ProxyServletTest.java > 1406188 > > Diff: https://reviews.apache.org/r/8951/diff/ > > > Testing > ------- > > Done. > > > Thanks, > > Marshall Shi > >
