> On Feb. 17, 2013, 1:59 p.m., Stanton Sievers wrote: > > Why not push the User-Agent value into the ProxyUriManager.ProxyUri object > > that gets passed into ProxyHandler's requests today instead of introducing > > a new parameter to all of the methods? You could set the User-Agent value > > on ProxyUri in ProxyServlet.processRequest(HttpServletRequest, > > HttpServletResponse) where all of the other params on the ProxyUri object > > get set. > > > > I think that would be a much cleaner approach unless there is a good reason > > not to do it that way.
Good point Stanton! I update the patch accordingly. It looks much cleaner. - Marshall ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/8951/#review16694 ----------------------------------------------------------- On Jan. 28, 2013, 4:51 a.m., Marshall Shi wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/8951/ > ----------------------------------------------------------- > > (Updated Jan. 28, 2013, 4:51 a.m.) > > > Review request for shindig, Ryan Baxter, Dan Dumont, Stanton Sievers, and > Rich Thompson. > > > Description > ------- > > The ProxyHandler currently does not forward the correct User-Agent to the > target server. We have certain cases that the target server needs to check > the User-Agent and decide the content of the response. > > > This addresses bug SHINDIG-1894. > https://issues.apache.org/jira/browse/SHINDIG-1894 > > > Diffs > ----- > > > http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/http/AbstractHttpCache.java > 1406188 > > http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/ProxyHandler.java > 1406188 > > http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/ProxyServlet.java > 1406188 > > http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/http/AbstractHttpCacheTest.java > 1406188 > > http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/render/ProxyRendererTest.java > 1406188 > > http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/servlet/ProxyServletTest.java > 1406188 > > Diff: https://reviews.apache.org/r/8951/diff/ > > > Testing > ------- > > Done. > > > Thanks, > > Marshall Shi > >
